Skip to content

Add SVM support for QAT compression#1

Open
cfzhu wants to merge 1 commit intomasterfrom
qat_enable_SVM
Open

Add SVM support for QAT compression#1
cfzhu wants to merge 1 commit intomasterfrom
qat_enable_SVM

Conversation

@cfzhu
Copy link
Owner

@cfzhu cfzhu commented May 31, 2022

  • Add SVM(Shared Virtual Memory) support for QAT compression
  • Fix the issue of repeatedly starting and stopping QAT devices
    under multi-thread mode.

Signed-off-by: Chengfei Zhu chengfei.zhu@intel.com

* Add SVM(Shared Virtual Memory) support for QAT compression
  If SVM is enabled, allocating physical contiguous memory and
  copying data between physical and virtual memory is not needed
  which can greatly reduce the memory copy cost.
* Fix the issue of repeatedly starting and stopping QAT devices
  under multi-thread mode.

Signed-off-by: Chengfei Zhu <chengfei.zhu@intel.com>
@cfzhu cfzhu force-pushed the qat_enable_SVM branch 2 times, most recently from f680c18 to 233090d Compare June 2, 2022 01:11
src/common/qat.c Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for SVM = shared virtual memory

src/common/qat.c Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here - If SVM (Shared Virtual Memory) is not enabled, we need to allocate physical contiguous memory for input and output data and copy the data from/to the virtual memory.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/common/qat.c Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here - If the SVM (Shared Virtual Memory) is enabled, the virtual memory address can be sent to QAT device directly, allocating physical contiguous memory is not required.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@wli5 wli5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit PR.
In your commit comment please add one more description of SVM in the first bullet, e.g.,
If SVM is enabled, allocating physical contiguous memory and copying data between physical and virtual memory is not needed which can greatly reduce the memory copy cost.

@cfzhu cfzhu force-pushed the qat_enable_SVM branch from 233090d to 4691a96 Compare June 7, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants