fix(all-users): handle program names in programs array#779
Closed
ismaeldosil wants to merge 7 commits intomasterfrom
Closed
fix(all-users): handle program names in programs array#779ismaeldosil wants to merge 7 commits intomasterfrom
ismaeldosil wants to merge 7 commits intomasterfrom
Conversation
- AllUsersPage.tsx / AllUsersTable.tsx - New admin page to view all users in the system with a sortable, filterable table - App.tsx / BurgerMenu.tsx - Added routing and navigation menu entry for the new "All Users" page - Firebase.tsx - New method fetchAllUsers() to retrieve all users from Firestore - Types.tsx - Extended User interface with optional fields (email, school, archived, lastLogin) for reuse across components - xlsxGenerator.ts - Added user export functionality using centralized Types.User - seed-full.js / seed-local.js / seed-local.sh - Scripts to populate local emulators with test data - .gitignore - Exclude internal project files - README.md - Documentation for local development setup - cypress/all-users.ts - E2E tests for the All Users feature - functions/package-lock.json - Updated Node engine (10→20) - yarn.lock - Dependency updates
fix: restore yarn.lock to fix CI parsing error
AllUsers page UI improvements
LeaderBoard All Users improvements
Add Leaderboard 'All users' loading state
fix(all-users): read legacy programId formats
fix(all-users): handle program names in programs array
Collaborator
Author
|
Recreating with cleaner history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
programs[]instead of IDprogramIdfieldRoot Cause
Some users have inconsistent data formats:
Changes in
getAllUsers()Now handles 3 formats in priority order:
programs[]array - tries as ID first, falls back to matching as nameprogramIdstring (legacy) - maps ID to nameprogramfield (legacy) - handles both ID and nameTest Results
Closes CHALK-080