Release: Last Action column and Edit dialog fixes#783
Closed
ismaeldosil wants to merge 13 commits intomasterfrom
Closed
Release: Last Action column and Edit dialog fixes#783ismaeldosil wants to merge 13 commits intomasterfrom
ismaeldosil wants to merge 13 commits intomasterfrom
Conversation
- AllUsersPage.tsx / AllUsersTable.tsx - New admin page to view all users in the system with a sortable, filterable table - App.tsx / BurgerMenu.tsx - Added routing and navigation menu entry for the new "All Users" page - Firebase.tsx - New method fetchAllUsers() to retrieve all users from Firestore - Types.tsx - Extended User interface with optional fields (email, school, archived, lastLogin) for reuse across components - xlsxGenerator.ts - Added user export functionality using centralized Types.User - seed-full.js / seed-local.js / seed-local.sh - Scripts to populate local emulators with test data - .gitignore - Exclude internal project files - README.md - Documentation for local development setup - cypress/all-users.ts - E2E tests for the All Users feature - functions/package-lock.json - Updated Node engine (10→20) - yarn.lock - Dependency updates
fix: restore yarn.lock to fix CI parsing error
AllUsers page UI improvements
LeaderBoard All Users improvements
Add Leaderboard 'All users' loading state
fix(all-users): read legacy programId formats
fix(all-users): handle program names in programs array
- Add getUsersLastAction() method with optimized batch queries - Query 5 collections in parallel (observations, knowledgeChecks, conferencePlans, actionPlans, emails) - Build Map<userId, lastDate> in memory for O(1) lookups - Add lastAction to User interface and getAllUsers() result - Add sortable "Last Action" column to AllUsersTable - Include Last Action in CSV export Performance: 5 queries total instead of 2,995 (599 users × 5 collections) Closes CHALK-090 Closes CHALK-091 Closes CHALK-092
feat(all-users): add Last Action column showing most recent activity
- Display action type (Observation, Training, Conference Plan, etc.) alongside date - Add lastActionType field to User interface - Update CSV export with Action Type column - Fix potential undefined email issue in Edit dialog Closes CHALK-090
feat(all-users): show action type in Last Action column
- Add edit dialog to UsersPage for All Users tab - Change Last Action format to "Action - Date" (action first) - Add archive confirmation dialog - Fix handleAllUserClick which was only logging Closes CHALK-090
fix(all-users): implement edit dialog and fix action format
Collaborator
Author
|
Recreating without package-lock noise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRs included
Test plan