Skip to content

feat: add requirement for commits to be either GPG or SSH key signed#25

Merged
AshleyCliff merged 1 commit intocharmed-hpc:mainfrom
NucciTheBoss:nuccitheboss/feat/gpg-sign
Aug 1, 2025
Merged

feat: add requirement for commits to be either GPG or SSH key signed#25
AshleyCliff merged 1 commit intocharmed-hpc:mainfrom
NucciTheBoss:nuccitheboss/feat/gpg-sign

Conversation

@NucciTheBoss
Copy link
Member

Pre-submission checklist

  • I read and followed the CONTRIBUTING guidelines.
  • I have ensured that lint, typecheck, and unit tests complete successfully.

Summary of changes

This PR makes it clear in our contributor documentation that GPG or SSH key signing your commits is a requirement for contributing to Charmed HPC.

Other changes:

  • Removed the illusion of choice for merging or rebasing on upstream. We only want rebases as merge commits add noise to the git history.

Related Issues, PRs, and Discussions

This PR is related to our ongoing work to update our community documentation.

Docs

  • I have created a pull request to add or update relevant documentation in charmed-hpc/docs or another documentation location.

Or:

  • I confirm that this pull request requires no changes or additions to documentation.

Other changes:

- Removed the illusion of choice for merging or rebasing on upstream.
  We only want rebases as merge commits add noise to the git history.

Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
@NucciTheBoss NucciTheBoss self-assigned this Aug 1, 2025
@NucciTheBoss NucciTheBoss requested a review from a team as a code owner August 1, 2025 14:18
@NucciTheBoss NucciTheBoss requested review from dsloanm and jedel1043 and removed request for a team August 1, 2025 14:18
Copy link
Contributor

@AshleyCliff AshleyCliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AshleyCliff AshleyCliff merged commit 21268f3 into charmed-hpc:main Aug 1, 2025
3 checks passed
@NucciTheBoss NucciTheBoss deleted the nuccitheboss/feat/gpg-sign branch December 19, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants