Skip to content

fix: avoid deleting labels on populated repositories#28

Merged
jedel1043 merged 1 commit intocharmed-hpc:mainfrom
jedel1043:fix-labels-tf
Oct 29, 2025
Merged

fix: avoid deleting labels on populated repositories#28
jedel1043 merged 1 commit intocharmed-hpc:mainfrom
jedel1043:fix-labels-tf

Conversation

@jedel1043
Copy link
Contributor

@jedel1043 jedel1043 commented Oct 29, 2025

Pre-submission checklist

  • I read and followed the CONTRIBUTING guidelines.
  • I have ensured that lint, typecheck, and unit tests complete successfully.

Summary of changes

The previous version of the labels plan had a bug that would delete all existing labels from a repository. This new version is not authoritative, in the sense that it will just append new labels to the repository or modify their name/color/description, and it won't touch already existing labels.

Docs

  • I confirm that this pull request requires no changes or additions to documentation.

@jedel1043 jedel1043 requested a review from a team as a code owner October 29, 2025 15:46
@jedel1043 jedel1043 requested review from NucciTheBoss and dsloanm and removed request for a team October 29, 2025 15:46
Copy link
Contributor

@dsloanm dsloanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jedel1043 jedel1043 merged commit 25ed160 into charmed-hpc:main Oct 29, 2025
3 checks passed
@jedel1043 jedel1043 deleted the fix-labels-tf branch October 29, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants