Skip to content
This repository was archived by the owner on Apr 30, 2025. It is now read-only.

Conversation

@alex-tu-cc
Copy link

It would be handy to also provide the URL of approved MP for reference.
Otherwise, members need to compose the project, author name, and merge ID manually to get the URL.

@yphus
Copy link
Contributor

yphus commented Aug 30, 2020

LP does provide the MR link, e.g:
(from https://code.launchpad.net/~checkbox-dev/checkbox-core-snap/+git/checkbox-core-snap/+ref/master)

7a98a54... by PMR pmr@pmr-lander on 2020-08-28

Merge #389854 from ~jocave/checkbox-core-snap:wrapper-common-add-gst-paths
Merged branch ~jocave/checkbox-core-snap:wrapper-common-add-gst-paths 

Clicking on "Merged" redirects you to the corresponding MR. What else is required?

@alex-tu-cc
Copy link
Author

I feel it would be more convenient that just provide a URL there, so that user screening git log locally can just open it.
Otherwise, user need to do several operations find out the MP page.

  1. open the project source web page depends on target branch (e.g. master, devl ..etc).
  2. search if the target commit on the 1st page. (the patch might not on 1st page)

And if the target commit not on 1st page, then user click 'All commits' and be redirected to https://git.launchpad.net/ , then user not able to just click "Merged" redirects to original MR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants