Skip to content

Conversation

@munechika-koyo
Copy link
Member

Add bolometer functionality to create an instance of BolometerCamera from bolometer IDS.

The rest of the changes are:

  • Add a new notebook to create emission models from full plasma.
  • Use dataclasses to handle well-typed values.
  • Introduce ultraplot for better plotting in notebooks
  • Add *.pyi files for Cython sources.

…ing in `load_cameras` and `from_value` methods
To handle geometry attributes effectively with type annotations.
munechika-koyo and others added 24 commits December 9, 2025 22:36
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 28.04233% with 272 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.50%. Comparing base (5a036bd) to head (4475266).
⚠️ Report is 60 commits behind head on master.

Files with missing lines Patch % Lines
src/cherab/imas/observer/bolometer.py 0.00% 124 Missing ⚠️
src/cherab/imas/ids/bolometer/_camera.py 0.00% 105 Missing ⚠️
src/cherab/imas/ids/bolometer/utility.py 0.00% 21 Missing ⚠️
src/cherab/imas/ids/common/ggd/load_unstruct_3d.py 66.66% 4 Missing ⚠️
src/cherab/imas/plasma/equilibrium.py 84.00% 0 Missing and 4 partials ⚠️
src/cherab/imas/ggd/unstruct_2d_extend_mesh.py 25.00% 3 Missing ⚠️
src/cherab/imas/ids/bolometer/__init__.py 0.00% 3 Missing ⚠️
src/cherab/imas/ids/common/ggd/load_grid.py 60.00% 0 Missing and 2 partials ⚠️
src/cherab/imas/ids/common/ggd/load_unstruct_2d.py 86.66% 0 Missing and 2 partials ⚠️
src/cherab/imas/observer/__init__.py 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   55.28%   49.50%   -5.78%     
==========================================
  Files          38       43       +5     
  Lines        1827     2137     +310     
  Branches      316      349      +33     
==========================================
+ Hits         1010     1058      +48     
- Misses        697      953     +256     
- Partials      120      126       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@munechika-koyo
Copy link
Member Author

munechika-koyo commented Jan 29, 2026

TODO:

  • Adding test for bolometry observer
  • Fix wheel build test

@munechika-koyo munechika-koyo merged commit 08c398b into master Jan 30, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants