Skip to content

fix: resolve 9 confirmed bugs — crashes, data races, logic errors, and resource leaks#6

Merged
cherryroots merged 10 commits intomainfrom
bug-fixes
Feb 23, 2026
Merged

fix: resolve 9 confirmed bugs — crashes, data races, logic errors, and resource leaks#6
cherryroots merged 10 commits intomainfrom
bug-fixes

Conversation

@cherryroots
Copy link
Owner

Summary

  • Crashes/panics: NaN timestamp and chunk-index panic in VideoToBase64Images; slice-bounds panic in SplitParagraph when code fence has no trailing newline
  • Resource leaks: HTTP response body leak in hasher.getFile when status is non-200 (TCP connection pool exhaustion)
  • Data races: resolution written in concurrent goroutines in draw command; msgCount/hashCount incremented without mutex in hash_server; blocking time.Sleep in AfterFunc callback in flushBuffer
  • Logic errors: playerTax returns negative value when player bets > 10% of money; Streamer.Stop() deadlocks if goroutine has already exited (unbuffered done channel); consolidation loop exits on REINFORCE without checking remaining facts for contradictions
  • Silent data loss: sqlite-vec ANN MATCH+k= queries apply user_id filter after the k-nearest scan, silently returning 0 results when other users' facts crowd the result set

Test Plan

  • go test ./... -timeout 60s — all packages pass
  • go build -race -o voltgpt — builds clean with race detector
  • Each fix has a companion test added before the fix (TDD)
  • Pre-existing ffmpeg-go@v0.5.0 race in Silent() confirmed on main — not introduced by this PR

🤖 Generated with Claude Code

@cherryroots cherryroots merged commit 38a0c43 into main Feb 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant