Skip to content

Fix/biquad #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grrrr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/biquad #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6a200
Remove unnecessary init
grrrr Dec 30, 2025
039a778
Fixes
grrrr Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions AudioFilterBiquad_F32.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class AudioFilterBiquad_F32 : public AudioStream_F32
public:
AudioFilterBiquad_F32(void): AudioStream_F32(1,inputQueueArray) {
setSampleRate_Hz(AUDIO_SAMPLE_RATE_EXACT);
sampleRate_Hz = AUDIO_SAMPLE_RATE_EXACT; // <<<<<<<<<<<<<<<<<<<<<< CHECK IF NEEDED??
doClassInit();
}
AudioFilterBiquad_F32(const AudioSettings_F32 &settings):
Expand All @@ -71,7 +70,7 @@ class AudioFilterBiquad_F32 : public AudioStream_F32
coeff32[ii] = 0.0;
coeff64[ii] = 0.0;
}
for(int ii=0; ii<4; ii++) {
for(int ii=0; ii<IIR_MAX_STAGES; ii++) {
coeff32[5*ii] = 1.0; // b0 = 1 for pass through
coeff64[5*ii] = 1.0;
}
Expand All @@ -83,7 +82,7 @@ class AudioFilterBiquad_F32 : public AudioStream_F32
// or from direct setCoefficients() need to be added to the double array
// and also to the float
void setCoefficients(int iStage, double *cf) {
if (iStage > IIR_MAX_STAGES) {
if (iStage >= IIR_MAX_STAGES) {
if (Serial) {
Serial.print("AudioFilterBiquad_F32: setCoefficients:");
Serial.println(" *** MaxStages Error");
Expand All @@ -96,7 +95,7 @@ class AudioFilterBiquad_F32 : public AudioStream_F32
coeff64[ii + 5*iStage] = cf[ii]; // The local collection of double coefficients
coeff32[ii + 5*iStage] = (float)cf[ii]; // and of floats
}
doBiquad = true;
begin();
}

// ARM DSP Math library filter instance.
Expand All @@ -107,6 +106,7 @@ class AudioFilterBiquad_F32 : public AudioStream_F32
// Initialize BiQuad instance (ARM DSP Math Library)
//https://www.keil.com/pack/doc/CMSIS/DSP/html/group__BiquadCascadeDF1.html
arm_biquad_cascade_df1_init_f32(&iir_inst, numStagesUsed, &coeff32[0], &StateF32[0]);
doBiquad = true;
}

void end(void) {
Expand Down