Fixed race condition with calculation for left and right coordinates …#127
Open
falkobuttler wants to merge 1 commit intochoefele:masterfrom
Open
Fixed race condition with calculation for left and right coordinates …#127falkobuttler wants to merge 1 commit intochoefele:masterfrom
falkobuttler wants to merge 1 commit intochoefele:masterfrom
Conversation
…of map view to calculate length This caused the cell size sometimes to be 0 due to a race condition when converting coordinates from the map view to its super view. When that happened, all annotations become invisible. This constantly happens when rotating, especially in flyover mode. Instead we are now calculating it against its own view, which always returns consistent and valid results.
Owner
|
Thanks for your PR. Could you please send me some step-by-step instructions how to reproduce the problem your are fixing with the sample app? I'd like to verify the solution of this issue. I'm not really sure how there would be a race condition around the super view of a view. Also, |
Owner
|
Also: your code causes the unit tests to fail because you changed the method parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…of map view to calculate length
This caused the cell size sometimes to be 0 due to a race condition when converting coordinates from the map view to its super view. When that happened, all annotations become invisible. This constantly happens when rotating, especially in flyover mode.
Instead we are now calculating it against its own view, which always returns consistent and valid results.