Avoid redundant declaration of error_number_to_condition with GCC -Wredundant-decls#1701
Open
pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
Open
Avoid redundant declaration of error_number_to_condition with GCC -Wredundant-decls#1701pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
Conversation
…edundant-decls GCC 14+ diagnoses a redundant redeclaration of asio::error::detail::error_number_to_condition(int) when error_code.ipp is included via error_code.hpp prior to the public declaration in error.hpp. Introduce a local guard macro to ensure the forward declaration is emitted only once per translation unit, while preserving existing inclusion paths and behavior. No functional or ABI changes. Fixes builds using -Wredundant-decls -Werror with GCC 14/15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 14+ diagnoses a redundant redeclaration of
when
impl/error_code.ippis included viaerror_code.hppprior to thepublic declaration in
error.hpp.Guard the forward declaration so it is emitted only once per
translation unit, while preserving existing inclusion order and
behavior.
No functional or ABI changes.
Fixes #1697.