Clarify IPv4 vs IPv6 semantics of multicast::outbound_interface#1702
Open
pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
Open
Clarify IPv4 vs IPv6 semantics of multicast::outbound_interface#1702pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
pinwhell wants to merge 1 commit intochriskohlhoff:masterfrom
Conversation
Clarify outbound_interface IPv4 vs IPv6 semantics chriskohlhoff#1690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multicast::outbound_interfaceconceptually represents a network interface.In IPv4, allowing construction from an
address_v4works because an address often uniquely identifies an interface.This assumption does not hold for IPv6, where an address does not uniquely identify a specific interface.
This change does not alter behavior, but clarifies the intended semantics by documenting that IPv6 requires specifying the interface index rather than an IPv6 address.
Related #1690.