Peek function and size reporting macros changes.#1
Open
arduzilla wants to merge 5 commits intochrismerck:masterfrom
Open
Peek function and size reporting macros changes.#1arduzilla wants to merge 5 commits intochrismerck:masterfrom
arduzilla wants to merge 5 commits intochrismerck:masterfrom
Conversation
Moved size reporting macros to the header file
1. Moved size reopting macros from the C file 2. Added macros giving number of elements taken and free 3. Added peek function prototy
Author
|
chrismerck
requested changes
Nov 20, 2023
rpa_queue.h
Outdated
| * @param queue Pointer to the rpa_queue_t instance. | ||
| * @return 1 if the queue is full, 0 otherwise. | ||
| */ | ||
| #define rpa_queue_full(queue) ((queue)->nelts == (queue)->bounds) |
Owner
There was a problem hiding this comment.
Thanks for the contribution, but can you do this with functions rather than macros? That would allow keeping the structure private (hidden in the .c file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added peek function taking the element without removing it from the queue. Also moved and added some size reporting functions