Update tidyflow for full tidymodels ecosystem compatibility#34
Open
gutama wants to merge 2 commits intocimentadaj:masterfrom
Open
Update tidyflow for full tidymodels ecosystem compatibility#34gutama wants to merge 2 commits intocimentadaj:masterfrom
gutama wants to merge 2 commits intocimentadaj:masterfrom
Conversation
Additional compatibility updates for tidymodels packages: - Replace deprecated tune::parameters() with hardhat::extract_parameter_set_dials() in R/parameters.R and R/pre-action-grid.R - Update minimum version requirements: - parsnip: 0.1.3 → 1.0.0 - tune: 0.1.0 → 1.0.0 - dials: 0.0.6 → 1.0.0 - hardhat: 0.1.2 → 1.0.0 - generics: 0.0.2 → 0.1.0 - Expand NEWS.md to document all tidymodels compatibility changes These changes ensure tidyflow works with the modern tidymodels ecosystem where the parameters() methods are deprecated in favor of extract_parameter_set_dials().
There was a problem hiding this comment.
Pull request overview
This pull request updates tidyflow to ensure compatibility with the modern tidymodels ecosystem (version 1.0.0+) by replacing deprecated API calls and updating minimum version requirements.
- Replaces deprecated
tune::parameters()withhardhat::extract_parameter_set_dials()for extracting tuning parameters - Updates minimum version requirements for core tidymodels packages to 1.0.0
- Documents all compatibility changes in NEWS.md
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| R/parameters.R | Updated parameters.tidyflow() method to use hardhat::extract_parameter_set_dials() instead of deprecated tune::parameters() |
| R/pre-action-grid.R | No functional changes; calls internal parameters() method which now uses the new API |
| NEWS.md | Documented breaking changes (version requirements) and internal changes (API replacements) |
| DESCRIPTION | Updated minimum version requirements for generics, hardhat, parsnip, tune, and dials packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
New features: - Add extract_* methods for tidymodels consistency (extract_fit_parsnip, extract_spec_parsnip, extract_preprocessor, extract_mold, extract_recipe, extract_parameter_set_dials) - Add plug_tune() for alternative tuning methods (tune_bayes, tune_sim_anneal, tune_race_anova, tune_race_win_loss) - Add control_bayes parameter to control_tidyflow() Improvements: - Improve error messages using cli package with contextual hints - Update documentation to reference new extract_* methods - Add "tune" to sacred_order in action.R for plug_tune support Files added: - R/extract.R: tidymodels-consistent extract_* methods - R/pre-action-tune.R: plug_tune/drop_tune/replace_tune functions
Owner
|
Hey, do you want to take over the package? I'm not giving any maintenance at all. |
Author
|
I am not really an expert on R, just learn a bit of AI tools. Your package is a really a good one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional compatibility updates for tidymodels packages:
Replace deprecated tune::parameters() with hardhat::extract_parameter_set_dials() in R/parameters.R and R/pre-action-grid.R
Update minimum version requirements:
Expand NEWS.md to document all tidymodels compatibility changes
These changes ensure tidyflow works with the modern tidymodels ecosystem where the parameters() methods are deprecated in favor of extract_parameter_set_dials().