Open
Conversation
The old way we retrieved the classpath wasn't ever supported by Java, it was an implementation detail on the JVM that got removed in Java 9, even though Java 9 was "backwards compatible", it broke code that wasn't officially supported.
- Used local variable type inference
- Made use of final consistent
- JavaApp already had a constructor that takes just the sourcecode and manages getting the classpath
- Used Java 8+ lambda syntax over new Runnable() { ..run } syntax
- Made variables more understandable. They were lacking context before that took a little too long to figure out on the first read, i.e:
- is input the filepath or the data that'll go in the file?
- is output the filepath or the data that'll go in the file?
- is source the filepath or the data that'll go in the file?
the answer was different for each of these but nothing about their names or type signified this, so I changed them.
Also "ret" isn't a good name.
Contributor
Author
|
I don't believe that Javadocs are functional in the current version of Gradle + Java 11. The issue is detailed in the following spots:
@jtnelson if you could take a look it'd be appreciated, hopefully I'm missing something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes about the upgrade
This means I don't have a good sense of how widespread this issue is in our codebase, but I know we use reflection quite a bit, so it would make sense that this is a large issue
TODO: