Skip to content

Fix package name validation#11

Merged
jamesponddotco merged 2 commits intotrunkfrom
james/fix-package-name-validation
May 25, 2025
Merged

Fix package name validation#11
jamesponddotco merged 2 commits intotrunkfrom
james/fix-package-name-validation

Conversation

@jamesponddotco
Copy link
Contributor

What does this PR do?

Simplify the package name validation regex to match what Go expects better and allow for names like x, which wasn't allowed before, but is allowed by Go.

Review checklist

Before submitting your PR, please review the following:

  • I have read the CONTRIBUTING.md file.
  • My changes are focused and address a single concern.
  • I have added/updated tests that prove my fix is effective or that
    my feature works.
  • New and existing tests pass locally with my changes.
  • I have added necessary documentation or made changes to
    documentation (if appropriate).
  • My changes generate no new warnings or errors.
  • My code follows the code style of this project.

Developer's certificate of origin

By submitting this pull request, I certify that:

  • The contribution is my own original work.
  • I have the right to submit it under the project's license.
  • I understand and agree to the project's contributing guidelines.

Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
@jamesponddotco jamesponddotco requested a review from Rayuaz May 19, 2025 22:15
@jamesponddotco jamesponddotco added the bug Something isn't working label May 19, 2025
@jamesponddotco jamesponddotco merged commit 702984d into trunk May 25, 2025
8 checks passed
@jamesponddotco jamesponddotco deleted the james/fix-package-name-validation branch May 25, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants