Skip to content

Add DEVELOPMENT.md#2

Merged
jamesponddotco merged 7 commits intotrunkfrom
james/add-development-instructions
Apr 13, 2025
Merged

Add DEVELOPMENT.md#2
jamesponddotco merged 7 commits intotrunkfrom
james/add-development-instructions

Conversation

@jamesponddotco
Copy link
Contributor

What does this PR do?

Add a DEVELOPMENT.md file with guidelines and instructions on how to develop pkgdex. Closes #1.

Review checklist

Before submitting your PR, please review the following:

  • I have read the CONTRIBUTING.md file.
  • My changes are focused and address a single concern.
  • I have added/updated tests that prove my fix is effective or that
    my feature works.
  • New and existing tests pass locally with my changes.
  • I have added necessary documentation or made changes to
    documentation (if appropriate).
  • My changes generate no new warnings or errors.
  • My code follows the code style of this project.

Developer's certificate of origin

By submitting this pull request, I certify that:

  • The contribution is my own original work.
  • I have the right to submit it under the project's license.
  • I understand and agree to the project's contributing guidelines.

Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
@jamesponddotco jamesponddotco added the documentation Improvements or additions to documentation label Mar 19, 2025
@jamesponddotco jamesponddotco requested a review from Rayuaz March 19, 2025 01:57
Copy link
Collaborator

@Rayuaz Rayuaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems with the make file, but that's not directly related to the changes in this PR. I'll create a new PR to fix those issues.

@jamesponddotco
Copy link
Contributor Author

jamesponddotco commented Mar 29, 2025

@Rayuaz Sorry for the delay, I can only work on this at night, but I have driving classes at night now, since I'm trying to get my license. I'll work on the issues you raised this weekend. Thanks for the review!

Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
Signed-off-by: James Pond <james@cipher.host>
@jamesponddotco
Copy link
Contributor Author

@Rayuaz When you have a second, can you review again, please?

@jamesponddotco jamesponddotco merged commit a0306e4 into trunk Apr 13, 2025
7 checks passed
@jamesponddotco jamesponddotco deleted the james/add-development-instructions branch April 13, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

Write a DEVELOPMENT.md file

2 participants