Encryption sanity checks #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
force-pushed
the
encryption-sanity-checks
branch
from
a6f7c84 to
6a27d0c
Compare
auxesis
requested changes
Dec 15, 2025
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
The encryption tests are good, but I don't think we should be introducing complexity into which builds run in what context.
Let's strip this PR down to just the encryption tests, and we can address the build changes in a separate PR.
tobyhede
force-pushed
the
encryption-sanity-checks
branch
from
c629f8f to
6a27d0c
Compare
…sure The identity closure |t| t in map_or_else is unnecessary. Using unwrap_or_else is more idiomatic when the Some value doesn't need transformation.
tobyhede
force-pushed
the
encryption-sanity-checks
branch
from
6a27d0c to
47592d1
Compare
Add support for unquoted PostgreSQL identifiers when setting keyset name via SET CIPHERSTASH.KEYSET_NAME. Previously only quoted strings and numbers were accepted; now valid PG identifiers work without quotes. Update tests to validate the new behavior and adjust invalid test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Add encryption verification tests to ensure data is actually encrypted, preventing silent mapping failures from going undetected.
Architecture: Create a reusable
assert_encryptedhelper incommon.rsthat queries the database directly (bypassing proxy) and asserts stored value differs from plaintext. Add one sanity check test per data type.