Add variant and metrics to events_plot mapping#223
Add variant and metrics to events_plot mapping#223frederichaase wants to merge 1 commit intoclearml:masterfrom
Conversation
|
Happy new year! |
|
Hi @Ponsaille, sorry for the delay 🙏 |
|
Hi @Ponsaille , @fhaase2 which version of ES do you use? We already have this mapping in events.json file and it is applied to all the events indices. While more specific mappings just add missing fields for specific event types. Thus the resulting indices have the mapping that is combination of events.json and then a more specific one like events_plot.json or events_log.json etc. This works for us in ES versions from 5.x to 7.x including. |
|
We use ES 8.5.1. And per default, the indices created automatically by ClearML have the wrong mappings in this version. So this PR makes sure that the created index has correct mapping, even in ES > 7.5. |
We had some issues with duplicated plots in our ClearML deployment.
The reason was that Elastiscearch infered
textfor these fields and we do an aggregation query.This PR sets them explicity to type
keyword, which should make it more stable given that field inference works slightly different in different Elasticsearch versions.