Fix file permissions from 0o777 to 0o755#40
Open
ColeMurray wants to merge 1 commit intoclearml:mainfrom
Open
Conversation
Changed overly permissive file permissions for dynamically created function files from 0o777 (world-writable) to 0o755 (owner-writable, world-readable/executable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes file permissions for dynamically created function files from
0o777(world-writable) to0o755(owner-writable, world-readable/executable).Changes
clearml_session/interactive_session_task.py:1629to use0o755instead of0o777when setting permissions for generated function filesRationale
Files created with
0o777permissions allow any user on the system to modify them. Using0o755follows the principle of least privilege while maintaining the necessary execute permissions.