Save custom attribute like wait_time in SeleniumRequest into Request.meta#67
Open
laggardkernel wants to merge 1 commit intoclemfromspace:developfrom
Open
Save custom attribute like wait_time in SeleniumRequest into Request.meta#67laggardkernel wants to merge 1 commit intoclemfromspace:developfrom
laggardkernel wants to merge 1 commit intoclemfromspace:developfrom
Conversation
The canonical way to share info between `Request` and download middleware is `Request.meta`. Custom attributes `Request.custom_attr` should be avoided, cause they may be dropped after possible serialization and de-serialization in `Scheduler`. E.g. `scrapy-redis` converts `Request` into dict with `scrapy.utils.reqpar.request_to_dict()`. Custom attribute on `Request` will be lost.
7844e32 to
8d9bf91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical way to share info between
Requestand download middleware isRequest.meta.Custom attributes
Request.custom_attrshould be avoided, cause it may be droppedafter possible serialization and de-serialization in
Scheduler.E.g.
scrapy-redisconvertsRequestinto dict withscrapy.utils.reqpar.request_to_dict(). Custom attribute onRequestwill be lost.