Open
Conversation
a4b64b4 to
0ea02ca
Compare
4b0557f to
25207a8
Compare
25207a8 to
7fc33ce
Compare
7fc33ce to
0ce10ed
Compare
c4eaf33 to
6ef834a
Compare
6ef834a to
82722f4
Compare
82722f4 to
55d485d
Compare
55d485d to
12e6f4d
Compare
12e6f4d to
3973386
Compare
3973386 to
332fbe8
Compare
| @@ -43,7 +43,7 @@ jobs: | |||
| fi | |||
There was a problem hiding this comment.
Bug: The workflow references a non-existent step pr to set the BASE_REF variable. This results in an empty string, causing the subsequent git rev-list command to fail.
Severity: HIGH
Suggested Fix
The environment variable BASE_REF is being set from a non-existent step output. To fix this, replace ${{ steps.pr.outputs.base_ref }} with the correct GitHub Actions context variable to obtain the base branch name. For workflows triggered by pull requests, github.base_ref is typically used. Ensure the variable provides a valid branch name to the git rev-list command.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/build.yaml#L43
Potential issue: The `build.yaml` workflow sets the `BASE_REF` environment variable
using the output of a step with `id: pr`. However, no such step exists in the workflow.
As a result, `BASE_REF` is assigned an empty string. This empty value is then used in
the "Check if commit exists" step within a `git rev-list` command, forming an invalid
git range `origin/..HEAD`. Because the script is configured with `set -eu`, this invalid
command will cause the step to fail, halting the workflow. This failure will occur on
every run triggered by pushes to `renovate/**` or `dependabot/**` branches, breaking the
CI process for automated dependency updates.
Did we get this right? 👍 / 👎 to inform future reviews.
332fbe8 to
6a41ebb
Compare
6a41ebb to
29ca63a
Compare
29ca63a to
4d75620
Compare
4d75620 to
87fbcfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
34e114849933ea733bb2cf2014bb153bb8e778341aConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.