chore(deps): update dependency @actions/github to v9#237
Open
renovate[bot] wants to merge 2 commits intomainfrom
Open
chore(deps): update dependency @actions/github to v9#237renovate[bot] wants to merge 2 commits intomainfrom
renovate[bot] wants to merge 2 commits intomainfrom
Conversation
032bfed to
e673e15
Compare
| @@ -22,7 +22,7 @@ | |||
| "homepage": "https://github.com/clevyr/deploy-matrix-action#readme", | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Bug: The build tool @vercel/ncc cannot bundle the new ESM-only @actions/github dependency, creating a broken artifact that will cause the action to crash at runtime.
Severity: CRITICAL
Suggested Fix
Update the build process to correctly handle ESM modules. This can be achieved by either upgrading @vercel/ncc to a version with proper ESM support or replacing it with an alternative bundler like esbuild or webpack. Alternatively, revert the @actions/github dependency to a CommonJS-compatible version until the build system is updated.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L23
Potential issue: The project's build tool, `@vercel/ncc@0.38.3`, does not correctly
handle the newly introduced ESM-only dependency `@actions/github@9.0.0`. While the build
command (`npm run build`) completes without error, it produces a non-functional
`dist/index.js` file that is missing the core application logic from `src/index.js`.
When the GitHub Action is triggered, it will attempt to execute this broken bundle,
resulting in a runtime crash and complete failure of the action.
Did we get this right? 👍 / 👎 to inform future reviews.
a2ec9bf to
b3f8f2d
Compare
f1c19e6 to
db73810
Compare
d7204f7 to
73ca392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.0.0→9.0.0Release Notes
actions/toolkit (@actions/github)
v9.0.0import()instead ofrequire()const { getOctokit, context } = await import('@​actions/github')@octokit/core/typesv8.0.1undicito6.23.0@actions/http-clientto3.0.2v8.0.0@octokit/core^7.0.6@octokit/plugin-paginate-rest^14.0.0@octokit/plugin-rest-endpoint-methods^17.0.0@octokit/request^10.0.7@octokit/request-error^7.1.0v7.0.0@actions/http-clientv6.0.1context.runAttempt#1588Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.