Addition of getbyid function#46
Open
jamesvillarrubia wants to merge 1 commit intoclickrain:masterfrom
Open
Conversation
Contributor
|
James, this is awesome. Thanks for your good work! This will be a great addition to EE_Twitter. Before I merge it, I have a few comments. The first one I'll make here, and the rest I'll make inline. First, can you please add the relevant documentation to the README? You should be able to mimic the style and tone of the other functions. |
Contributor
There was a problem hiding this comment.
Would this be better as {exp:twitter:tweet id="..."} or {exp:twitter:single_tweet id="..."}? {exp:twitter:getbyid} doesn't seem to have much flow to it. What am I getting by ID?
Contributor
|
Well now I feel bad, but don't be discouraged. Clean up those items and this will be ready to pull. Thanks again for the solid pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new tag that pulls a single tweet directly through it's twitter id.