Sourcery Starbot ⭐ refactored closedLoop/fintech-sandbox-curation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
May 3, 2021
Comment on lines
-62
to
+85
| args = (Timestamp, default, StoryId, Country, Sentiment, \ | ||
| Confidence, Novelty, Subjects, Relevance, Ticker, Timestamp, \ | ||
| Ticker, Timestamp, default, StoryId, Timestamp, Country, \ | ||
| Sentiment, Confidence, Novelty, Subjects, Relevance) | ||
|
|
||
| return args | ||
| return ( | ||
| Timestamp, | ||
| default, | ||
| StoryId, | ||
| Country, | ||
| Sentiment, | ||
| Confidence, | ||
| Novelty, | ||
| Subjects, | ||
| Relevance, | ||
| Ticker, | ||
| Timestamp, | ||
| Ticker, | ||
| Timestamp, | ||
| default, | ||
| StoryId, | ||
| Timestamp, | ||
| Country, | ||
| Sentiment, | ||
| Confidence, | ||
| Novelty, | ||
| Subjects, | ||
| Relevance, | ||
| ) |
Author
There was a problem hiding this comment.
Function parse_line refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-15
to
+16
| data = json.loads(jsonData, object_hook=lambda d: namedtuple('data', d.keys())(*d.values())) | ||
| return data | ||
| return json.loads( | ||
| jsonData, object_hook=lambda d: namedtuple('data', d.keys())(*d.values())) |
Author
There was a problem hiding this comment.
Function convertJsonTuple refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-31
to
+35
| formatted_parameters = '&'.join('{0}={1}'.format(key, ''.join([str(var) for var in val])) for key, val in sorted(url_parameters.items())) | ||
| formatted_parameters = '&'.join( | ||
| '{0}={1}'.format(key, ''.join(str(var) for var in val)) | ||
| for key, val in sorted(url_parameters.items()) | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function XigniteEconomicCalendar.construct_url refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Comment on lines
-32
to
+36
| formatted_parameters = '&'.join('{0}={1}'.format(key, ','.join([str(var) for var in val])) for key, val in sorted(url_parameters.items())) | ||
| formatted_parameters = '&'.join( | ||
| '{0}={1}'.format(key, ','.join(str(var) for var in val)) | ||
| for key, val in sorted(url_parameters.items()) | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function XigniteGlobalQuotes.construct_url refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Comment on lines
-28
to
+30
|
|
||
| soup = BeautifulSoup(html, 'lxml') | ||
|
|
Author
There was a problem hiding this comment.
Function process_article refactored with the following changes:
- Extract guard clause from elif block (
guard) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-225
to
+221
|
|
Author
There was a problem hiding this comment.
Function create_markup_table refactored with the following changes:
- Merge append into list declaration (
merge-list-append) - Replace unneeded comprehension with generator (
comprehension-to-generator)
| Evaluate if sql statement will return data or not | ||
| """ | ||
| return True if 'CREATE' in sql or 'UPDATE' in sql or 'INSERT' in sql or 'DELETE' in sql else False | ||
| return 'CREATE' in sql or 'UPDATE' in sql or 'INSERT' in sql or 'DELETE' in sql |
Author
There was a problem hiding this comment.
Function nothing_to_return refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity)
Comment on lines
-49
to
+53
| return tuple([desc[0] for desc in c.description]) + rows if return_columns else rows | ||
| return ( | ||
| tuple(desc[0] for desc in c.description) + rows | ||
| if return_columns | ||
| else rows | ||
| ) |
Author
There was a problem hiding this comment.
Function execute refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: