Skip to content

fix test by replacing %w with %v #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgerhardt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix test by replacing %w with %v #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions ch05/ch05_08/filelogger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,16 @@ func fileExists(filename string) bool {

func TestCreateLogger(t *testing.T) {
const filename = "/tmp/create-logger.txt"
defer os.Remove(filename)
t.Cleanup(func() {
err := os.Remove(filename)
if err != nil {
return
}
})

tl, err := NewFileTransactionLogger(filename)
if err != nil {
t.Errorf("Got error: %w", err)
t.Errorf("Got error: %v", err)
}
if tl == nil {
t.Error("Logger is nil?")
Expand All @@ -48,14 +53,24 @@ func TestCreateLogger(t *testing.T) {

func TestLastSequence(t *testing.T) {
const filename = "/tmp/last-sequence.txt"
defer os.Remove(filename)
t.Cleanup(func() {
err := os.Remove(filename)
if err != nil {
return
}
})

tl, err := NewFileTransactionLogger(filename)
if err != nil {
t.Error(err)
}
tl.Run()
defer tl.Close()
t.Cleanup(func() {
closeErr := tl.Close()
if closeErr != nil {
return
}
})

evaluateLastSequence(t, tl, 0)

Expand All @@ -73,14 +88,24 @@ func TestLastSequence(t *testing.T) {

func TestWriteAppend(t *testing.T) {
const filename = "/tmp/write-append.txt"
defer os.Remove(filename)
t.Cleanup(func() {
err := os.Remove(filename)
if err != nil {
return
}
})

tl, err := NewFileTransactionLogger(filename)
if err != nil {
t.Error(err)
}
tl.Run()
defer tl.Close()
t.Cleanup(func() {
closeErr := tl.Close()
if closeErr != nil {
return
}
})

chev, cherr := tl.ReadEvents()
for e := range chev {
Expand Down Expand Up @@ -122,11 +147,21 @@ func TestWriteAppend(t *testing.T) {

func TestWritePut(t *testing.T) {
const filename = "/tmp/write-put.txt"
defer os.Remove(filename)
t.Cleanup(func() {
err := os.Remove(filename)
if err != nil {
return
}
})

tl, _ := NewFileTransactionLogger(filename)
tl.Run()
defer tl.Close()
t.Cleanup(func() {
closeErr := tl.Close()
if closeErr != nil {
return
}
})

tl.WritePut("my-key", "my-value")
tl.WritePut("my-key", "my-value2")
Expand Down