This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Open
Conversation
Contributor
|
not true. undefined simply resolves to an IP address on that machine because of *.cloudant.com. |
Contributor
Author
|
Whut? |
The call to `inet:getaddr/2` will return a valid IP on `*.cloudant.com` hosts due to our DNS configuration. This avoids the entire call when we have not configured a syslog host. This change was motivated by Jenkins which wasn't logging during `make check` runs. BugzId: 26411
Contributor
Author
|
Commit message updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
inet:getaddr/2will return a valid IP on*.cloudant.comhosts due to our DNS configuration. This avoids the entire call when we
have not configured a syslog host.
This change was motivated by Jenkins which wasn't logging during
make checkruns.BugzId: 26411