This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Open
Conversation
Contributor
|
lgtm |
Contributor
|
Perhaps we should move access logs down to debug level and record logs at info instead of notice? As it stands now we won’t see the output of this PR in our infra, right? |
Contributor
Author
|
Doh. Good call on info logging. I'll update that notice. As to HTTP logging I think I'd like to just add an option to turn that on or off. Moving it to debug might also make sense regardless. |
This is intended to help us debug errors during node boots. The two particular cases are when a node appears to be half awake responding to RPC requests while the HTTP interfaces aren't live. The second is a developer friendliness issue when a node fails to boot with the opaque "init terminating in do_boot" error. BugzId: 28716
Contributor
Author
|
Safari does not like the GitHub ajaxy stuff... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to help us debug errors during node boots. The two
particular cases are when a node appears to be half awake responding to
RPC requests while the HTTP interfaces aren't live.
The second is a developer friendliness issue when a node fails to boot
with the opaque "init terminating in do_boot" error.
BugzId: 28716