fix: works with TBC Classic 2.5.4, missing TomTom/location stuff#19
Open
mhco wants to merge 11 commits intocloudbells:masterfrom
Open
fix: works with TBC Classic 2.5.4, missing TomTom/location stuff#19mhco wants to merge 11 commits intocloudbells:masterfrom
mhco wants to merge 11 commits intocloudbells:masterfrom
Conversation
Author
|
I'm currently working on adding the rest of the professions to the addon, but I figured that can be worked on before the next release, but after the initial changes are merged. I'll need help with adding fish levels, herbs, etc., to speed things up. |
Owner
|
Hey! This is obviously a ton of work and I'm a little humbled someone would take the time to make this addon work again. I could not find a way to contact you, could you send me an email (address is on my profile) before I go through this PR? |
added 8 commits
April 11, 2022 16:11
…ith "/fg version"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big TBC Classic Compatibility Update
Features:
Warning: TomTom and Location features are removed from this version temporarily
I stripped out the TomTom and location stuff in order to get this working with TBC. These features are not incompatible with my version of the addon, but I removed them to simplify the addon while I was working on it. My main goal was to get the spells working, so I got rid of code that didn't matter so I could focus on what did. TomTom and trainer location features can be easily re-added to the addon, but users should be aware that they aren't currently there.
To do: