Generate dummy mlkem bindings if mlkem.h is missing #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
reviewed
Feb 10, 2026
|
|
||
| fn fail() { | ||
| unsafe { | ||
| ERR_put_error( |
Member
There was a problem hiding this comment.
This only records an error, right? Doesn't halt the execution.
Collaborator
Author
There was a problem hiding this comment.
Yeah. I've renamed it to just put_error.
kornelski
force-pushed
the
dummy-mlkem
branch
2 times, most recently
from
baeef71 to
73f7b62
Compare
kornelski
force-pushed
the
dummy-mlkem
branch
from
73f7b62 to
36a547e
Compare
kornelski
force-pushed
the
dummy-mlkem
branch
from
36a547e to
fb69e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #470
If C lacks MLKEM APIs, and the
mlkemCargo feature isn't requiring a real MLKEM support,boring-syswill inject an always-failing fallback to allow Rust bindings to fail at run time instead of compile time.It uses a glob to add the fallback, because Rust always prefers real definitions over globs, so the real definitions will be used if they're available.