Fix missing sandbox.start() call in middleware#315
Closed
04cb wants to merge 1 commit intocloudflare:mainfrom
Closed
Fix missing sandbox.start() call in middleware#31504cb wants to merge 1 commit intocloudflare:mainfrom
04cb wants to merge 1 commit intocloudflare:mainfrom
Conversation
The sandbox middleware was getting a sandbox instance but never calling sandbox.start() before setting it in the Hono context. This caused containerFetch and wsConnect to fail with 'container is not running' errors. Fixed by adding await sandbox.start() before setting the sandbox in context. The start() method is idempotent and safe to call on every request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291.
The sandbox middleware was getting a sandbox instance but never calling sandbox.start() before setting it in the Hono context. This caused containerFetch and wsConnect to fail with 'container is not running' errors on every request.
Fixed by adding await sandbox.start() before setting the sandbox in context. The start() method is idempotent (no-op if already running) so calling it on every request is safe.