Makefile: avoid unnecessary rebuilds of the library#173
Merged
Lekensteyn merged 1 commit intomasterfrom Aug 9, 2019
Merged
Conversation
7926b4c to
234ff88
Compare
Contributor
Author
|
Changes since the initial PR:
Initially the Makefile depended on |
234ff88 to
ed4428f
Compare
* Do not wipe GOROOT for every `_dev/go.sh` invocation. * Do not clone sidh and nobs repositories when only tris has changed. * Do not copy and rebuild stdlib when only crypto/tls has changed. * Avoid creating a temporary directory on every make invocation. * Avoid creating src/src/ when the src/ directory already exists.
ed4428f to
551e57e
Compare
Contributor
Author
|
Hi @henrydcase, any comments on this patch? It would remove unnecessary git clones during the build and speed up development. |
wbl
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_dev/go.shinvocation.Important fix for integration of Tris in external projects which use the
_dev/go.shwrapper. WIthout this fix, it would rebuild Tris for every singlegoinvocation.