Fix: CORS headers not being applied to requests#61
Open
rivenintech wants to merge 1 commit intocloudflare:masterfrom
Open
Fix: CORS headers not being applied to requests#61rivenintech wants to merge 1 commit intocloudflare:masterfrom
rivenintech wants to merge 1 commit intocloudflare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from #60, which I accidentally deleted 😅:
This PR fixes an issue where CORS headers were not being applied, due to the wrong order (routes before middleware).
I came across this issue when I tried to fetch the GraphQL endpoint from React.
By moving the middleware above the routes, as it is done in the Hono documentation, we ensure they are applied to all requests.