Remove hardcoded values from key_length validation unit test#34
Closed
yuriadam-sap wants to merge 0 commit intocloudfoundry:developfrom
Closed
Remove hardcoded values from key_length validation unit test#34yuriadam-sap wants to merge 0 commit intocloudfoundry:developfrom
yuriadam-sap wants to merge 0 commit intocloudfoundry:developfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
yuriadam-sap
force-pushed
the
adjust-rsa-validation
branch
from
88bd4ce to
4067122
Compare
github-project-automation
bot
moved this from Inbox
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded key length values from the validation test assertion.
Instead of checking for the exact string "Must be one of: [2048 3072 4096]", the test now only verifies that the error message contains "Must be one of:".
This ensures the test remains valid if additional standard RSA key sizes are added in the future.