Fix/player ref beta #650
Open
Fix/player ref beta #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small internal improvement that I think is worth taking. This makes sure that the repository is using only a single package manager and switches away from using relative paths to reach out across workspace boundaries cc @colbyfayock --------- Co-authored-by: Colby Fayock <fayock@gmail.com>
…ty#520) # Description This PR switches away from tsup to preconstruct - a lesser-known but more capable tool. The benefits are: - better cjs & esm setup - and types for the above (this should pass https://arethetypeswrong.github.io/ checks) - `'use client'` directive support. With this you just can just add the directive to any of your files and Preconstruct takes care of isolating that in its own chunk - `package.json#exports` flexibility: - it should be possible to add extra entrypoints with ease if you ever need that (like `next-cloudinary/something`) - it's also easy to use differential bundling with this, if you ever need to ship different code for dev/prov bundles, or for node/browser/webworker/vercel's edge-light/younameit (or perhaps for `react-server` condition) ## Issue Ticket Number Related to cloudinary-community#435 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation BREAKING CHANGE: New build tool, no longer requires `use client` directive, marking as breaking for safety
# [7.0.0-beta.1](cloudinary-community/next-cloudinary@v6.13.0...v7.0.0-beta.1) (2024-09-27) ### Features * Switch to Preconstruct for library building ([cloudinary-community#520](cloudinary-community#520)) ([a35a928](cloudinary-community@a35a928)) ### BREAKING CHANGES * New build tool, no longer requires `use client` directive, marking as breaking for safety
# [7.0.0-beta.2](cloudinary-community/next-cloudinary@v7.0.0-beta.1...v7.0.0-beta.2) (2024-10-03) ### Bug Fixes * make sure to publish types ([cloudinary-community#528](cloudinary-community#528)) ([b1d1f61](cloudinary-community@b1d1f61))
# [7.0.0-beta.3](cloudinary-community/next-cloudinary@v7.0.0-beta.2...v7.0.0-beta.3) (2024-10-14) ### Bug Fixes * removed ts-ignore ([cloudinary-community#535](cloudinary-community#535)) ([32931c9](cloudinary-community@32931c9)), closes [cloudinary-community#426](cloudinary-community#426) * use more proper type to derive `CldVideoPlayerProps` ([cloudinary-community#537](cloudinary-community#537)) ([65c3dd1](cloudinary-community@65c3dd1)) ### Features * added unique id generation using React's `useId()` hook ([cloudinary-community#529](cloudinary-community#529)) ([682f4c2](cloudinary-community@682f4c2)), closes [cloudinary-community#493](cloudinary-community#493)
# [7.0.0-beta.4](cloudinary-community/next-cloudinary@v7.0.0-beta.3...v7.0.0-beta.4) (2024-10-15) ### Features * Log x-cld-error on image error ([cloudinary-community#553](cloudinary-community#553)) ([711c759](cloudinary-community@711c759)), closes [cloudinary-community#512](cloudinary-community#512)
…rops are exported
…how props are exported
# [7.0.0-beta.5](cloudinary-community/next-cloudinary@v7.0.0-beta.4...v7.0.0-beta.5) (2024-10-25) ### Bug Fixes * upgrading util packages to beta which refactors type system and how props are exported ([08a60de](cloudinary-community@08a60de))
# [7.0.0-beta.6](cloudinary-community/next-cloudinary@v7.0.0-beta.5...v7.0.0-beta.6) (2024-10-31) ### Bug Fixes * oops, pnpm lock ([d2e115e](cloudinary-community@d2e115e)) * upgrading url-loader to new beta ([edeee00](cloudinary-community@edeee00))
# [7.0.0-beta.7](cloudinary-community/next-cloudinary@v7.0.0-beta.6...v7.0.0-beta.7) (2024-10-31) ### Bug Fixes * upgrading util packages, fixing prop definitions ([94e9e87](cloudinary-community@94e9e87))
# [7.0.0-beta.8](cloudinary-community/next-cloudinary@v7.0.0-beta.7...v7.0.0-beta.8) (2024-11-01) ### Bug Fixes * lockfile ([cb44682](cloudinary-community@cb44682)) ### Features * nextjs 15 support in package.json ([fb75bff](cloudinary-community@fb75bff))
# [7.0.0-beta.9](cloudinary-community/next-cloudinary@v7.0.0-beta.8...v7.0.0-beta.9) (2024-11-01) ### Bug Fixes * upgrading to stable releases for url-loader and util packages ([1b9c160](cloudinary-community@1b9c160))
…-community#552) # Description This PR will add the `src` type to `CloudinaryLoaderCldOptions` interface to fix the ts error being thrown from the `cloudinary-loader.ts` file. Fixes This will close cloudinary-community#425 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/cloudinary-community/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/cloudinary-community/next-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/cloudinary-community/next-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes needed to the documentation --------- Co-authored-by: Colby Fayock <fayock@gmail.com>
# [7.0.0-beta.10](cloudinary-community/next-cloudinary@v7.0.0-beta.9...v7.0.0-beta.10) (2024-11-01) ### Bug Fixes * add src type to CloudinaryLoaderCldOptions interface ([cloudinary-community#552](cloudinary-community#552)) ([74e1b96](cloudinary-community@74e1b96)), closes [cloudinary-community#425](cloudinary-community#425)
…loudinary into beta # Conflicts: # pnpm-lock.yaml
This brings the seed parameter to fillBackground
# [7.0.0-beta.11](cloudinary-community/next-cloudinary@v7.0.0-beta.10...v7.0.0-beta.11) (2025-09-16) ### Bug Fixes * updating util packages ([56910f1](cloudinary-community@56910f1))
…til/util to 4.2.0
…ade-url-loader-6.2.0 chore: upgrade @cloudinary-util/url-loader to 6.2.0 and @cloudinary-util/util to 4.2.0
|
@eportis-cloudinary is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Ticket Number
Fixes #<ISSUE_NUMBER>
Type of change
Checklist