Skip to content

Conversation

@FloorD
Copy link
Contributor

@FloorD FloorD commented Dec 16, 2025

@mmols would love to hear what you think.
Team, I know I need to adjust column width still.

@FloorD FloorD requested a review from a team as a code owner December 16, 2025 13:48
Copy link
Contributor

@jsilvela jsilvela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of typos, several suggestions.
On the column width thing (I did see you mention it, yes): for the code review, making a correction makes one modify a whole paragraph, rather than a single line.

Copy link
Contributor

@mmols mmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FloorD This looks great - thank you for putting it together.

My only ask is to remove the exclamations at the end of the quotes (three instances) - the tone is a bit off with them.

@sxd sxd force-pushed the interview-pgedge branch from c7600a5 to e59add4 Compare January 2, 2026 10:01
FloorD and others added 9 commits January 2, 2026 11:01
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Update w/ Matt's suggestions and column width

Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
@sxd sxd force-pushed the interview-pgedge branch from e59add4 to 293d552 Compare January 2, 2026 10:01
@sxd sxd merged commit 79443c2 into main Jan 2, 2026
4 checks passed
@sxd sxd deleted the interview-pgedge branch January 2, 2026 10:03
github-actions bot pushed a commit that referenced this pull request Jan 2, 2026
Signed-off-by: Floor Drees <floordrees@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Signed-off-by: Jaime Silvela <jaime.silvela@mailfence.com>
Co-authored-by: Jaime Silvela <jaime.silvela@enterprisedb.com> 79443c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants