This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Closed
Conversation
amanenk
commented
Jul 23, 2022
| t.Fatal("failed to configure provider", configErr) | ||
| } else if resp != nil && resp.Diagnostics.HasErrors() { | ||
| t.Fatal("errors while configuring provider", configErr) | ||
| t.Fatal("errors while configuring provider", resp.Diagnostics.Error()) |
Contributor
Author
There was a problem hiding this comment.
should we print only errors in resp.Diagnostics.Error function or it is ok to print all the diags?
Contributor
|
We are going to remove diags. so let's hold with any code that touches it atm. there are a lot of bugs related to that but they will partially go away with #437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixed print of provider configuration error when error is in diags.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)