Open
Conversation
Conflicts: layout-test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @cmather - this solves the basic "what should the default data for a yield region (or layout template) be" problem. It defaults to whatever the data context of
{{#Layoutwas, unless you calllayout.setData().I think this is natural and what users would expect.
There's a secondary issue (encapsulated in the commented out test) where the yields don't get the data context you might expect. I don't actually use this and I'm not 100% sure what is the correct behaviour so I propose we leave as is for now. But I think I could change it easily enough if you feel strongly about it.
PS. If you turn on logging I see
getData()logged a lot. I'm not sure if this is normal or some weird side effect of this change?Fixes #1