Repository cleanup by aehart · Pull Request #8 · cms-data/L1Trigger-TrackFindingTracklet

aehart · 2025-07-10T13:57:18Z

This PR includes three changes:

removes files that are not only obsolete but, in most cases, incompatible with the current code in L1Trigger/TrackFindingTracklet
adds a JSON file that contains an equivalent description of the wiring contained in the DAT files; this easier-to-edit format will become the default description in the near future
updates the README to reflect the new repository contents

Just to be clear, none of the files that are removed or added by this PR are currently used in L1Trigger/TrackFindingTracklet by default.

@tomalin

cmsbuild · 2025-07-10T13:58:09Z

A new Pull Request was created by @aehart for branch master.

@BenjaminRS, @akritkbehera, @cmsbuild, @iarspider, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-07-10T13:58:10Z

cms-bot internal usage

cmsbuild · 2025-07-23T14:38:27Z

Pull request #8 was updated.

aehart · 2025-07-23T14:40:47Z

Just FYI, seedWiring.json, which is added to the repository in this PR, has been further refined to remove superfluous projections that are not allowed by the C++ code.

tomalin · 2025-10-08T22:38:22Z

Hi all, had two PRs to this repository pending for ages, for no apparent reason. Can someone please merge them?

iarspider · 2025-10-09T07:08:23Z

Is there a cmssw pr to test this PR with? Or is it a standalone pr?
Also, the L1 signature is missing.

tomalin · 2025-11-06T10:43:24Z

@iarspider This PR is just a clean up . It can be used with any recent CMSSW version, and result should be unaffected.

smuzaffar · 2025-12-02T10:39:31Z

please test using full cmssw

cmsbuild · 2025-12-02T17:10:25Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/summary.html
COMMIT: 67dc0fe
CMSSW: CMSSW_16_0_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Update tag for RecoEgamma-EgammaPhotonProducers to V00-06-00 cms-sw/cmsdist#10231

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

Failed RelVals

34434.911

----- Begin Fatal Exception 02-Dec-2025 17:40:32 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.911_TTbar_14TeV+Run4D121_DD4hep


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

34434.0

----- Begin Fatal Exception 02-Dec-2025 17:32:43 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.0_TTbar_14TeV+Run4D121


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

34434.75

----- Begin Fatal Exception 02-Dec-2025 17:33:15 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

tomalin · 2025-12-08T12:52:54Z

@aehart The reason this PR fails is that there are still references in the C++ code of L1Trigger/TrackFindingTracklet/ to TREFile and TEDFile. As far as I can tell, the code makes no use of these, so I'd suggest we make a PR to central CMSSW to delete them all (or comment them out if the intention is to use them to apply cuts to the displaced tracking at some point in future?).
N.B. In our L1 track development branch, the contents of our L1Trigger/TrackFindingTracklet/data/ directory correspond to your PR. I was therefore surprised that we had not observed the same crash there. The reason it does not happen is that the utility FileInPath first searches for any txt file it wants in your local area, and if it can't find them there, it then looks in the official CMSSW area. And as these txt files have not yet been deleted from cms-data, it was finding them there.

cmsbuild · 2026-01-30T16:31:34Z

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with cms-sw/cmssw#49779, please check if they should be merged together

BenjaminRS · 2026-01-30T16:38:16Z

test parameters:

workflow = 29634.78
pull_request = Cleanup of obsolete lookup tables cms-sw/cmssw#49779
relvals_opt = --what upgrade

BenjaminRS · 2026-01-30T16:39:06Z

please test

cmsbuild · 2026-01-30T19:05:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/51023/summary.html
COMMIT: 67dc0fe
CMSSW: CMSSW_16_1_X_2026-01-30-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/51023/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich provide defaults to fillDescriptions parameters for RecoLocalTracker/SiStripClusterizer alpaka plugins cms-sw/cmssw#49982

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/51023/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/51023/git-merge-result

Comparison Summary

Summary:

You potentially added 17 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4170992
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4170966
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

BenjaminRS · 2026-01-30T19:55:33Z

+l1

BenjaminRS · 2026-02-03T14:01:19Z

Pinging @smuzaffar for the external sign please

smuzaffar · 2026-02-03T14:08:36Z

+externals

thanks for the cleanup

cmsbuild · 2026-02-03T14:09:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2026-02-03T15:00:53Z

I only see https://github.com/search?q=repo%3Acms-sw%2Fcmssw%20L1Trigger%2FTrackFindingTracklet%2Fdata&type=code references in cmssw. None of the removed file is mentioned there. So it should be fine to merge this PR.

aehart added 3 commits July 8, 2025 14:48

Removed obsolete files.

7ba117f

Added wiring JSON to replace *.dat files in the future.

980e1c3

Updated README.

84bce1c

cmsbuild added l1-pending orp-pending externals-pending pending-signatures tests-pending labels Jul 10, 2025

aehart mentioned this pull request Jul 23, 2025

Cleaning seedWiring.json cms-L1TK/cmssw#325

Closed

Removed unallowed projections from seedWiring.json.

67dc0fe

cmsbuild added tests-started and removed tests-pending labels Dec 2, 2025

cmsbuild added tests-rejected and removed tests-started labels Dec 2, 2025

aehart mentioned this pull request Jan 12, 2026

Cleanup of obsolete lookup tables cms-sw/cmssw#49779

Merged

cmsbuild added the requires-external label Jan 30, 2026

cmsbuild removed the tests-rejected label Jan 30, 2026

cmsbuild added the tests-started label Jan 30, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2026

cmsbuild added l1-approved and removed l1-pending labels Jan 30, 2026

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Feb 3, 2026

Conversation

aehart commented Jul 10, 2025

Uh oh!

cmsbuild commented Jul 10, 2025

Uh oh!

cmsbuild commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jul 23, 2025

Uh oh!

aehart commented Jul 23, 2025

Uh oh!

tomalin commented Oct 8, 2025

Uh oh!

iarspider commented Oct 9, 2025

Uh oh!

tomalin commented Nov 6, 2025

Uh oh!

smuzaffar commented Dec 2, 2025

Uh oh!

cmsbuild commented Dec 2, 2025

Failed Unit Tests

Failed RelVals

Uh oh!

tomalin commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 30, 2026

Uh oh!

BenjaminRS commented Jan 30, 2026

Uh oh!

BenjaminRS commented Jan 30, 2026

Uh oh!

cmsbuild commented Jan 30, 2026

Comparison Summary

Uh oh!

BenjaminRS commented Jan 30, 2026

Uh oh!

BenjaminRS commented Feb 3, 2026

Uh oh!

smuzaffar commented Feb 3, 2026

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

smuzaffar commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Jul 10, 2025 •

edited

Loading

tomalin commented Dec 8, 2025 •

edited

Loading