refactor(aurora-portal): extract shared formatBytes utility with binary and decimal support#511
Open
mark-karnaukh-extern-sap wants to merge 2 commits intomainfrom
Open
refactor(aurora-portal): extract shared formatBytes utility with binary and decimal support#511mark-karnaukh-extern-sap wants to merge 2 commits intomainfrom
mark-karnaukh-extern-sap wants to merge 2 commits intomainfrom
Conversation
…ry and decimal support
5 tasks
vlad-schur-external-sap
approved these changes
Feb 19, 2026
TilmanHaupt
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts duplicated inline
formatBytesimplementations from multiple components into a single shared utility supporting both binary (IEC) and decimal (SI) unit systems.Changes
New
src/client/utils/formatBytes.ts— shared utility withformatBytes,formatBytesDecimal,formatBytesBinaryUpdated
SizeDisplay.tsx— replaced inline implementation withformatBytesDecimalContainerListView.tsx— replaced inline implementation with shared utilityList.tsx— replaced inline implementation with shared utilityTests
formatBytes.test.ts— new, full coverage of both unit systems, edge cases, decimals optionSizeDisplay.test.tsx— updated expected values to match SI outputImageDetailsView.test.tsx— fixedsizeinputs to SI-round boundariesDeleteImageModal.test.tsx— fixedsize: 1024→size: 1000Notes
SizeDisplayusesformatBytesDecimal(SI) — appropriate since OpenStack APIs return raw byte counts, not binary-aligned values. Test fixtures that previously used binary boundaries (e.g.1073741824,1024) were updated to SI-round equivalents (e.g.1000000000,1000) to produce clean expected values.Checklist