sql/schemachanger: implement CREATE OR REPLACE TRIGGER#162633
Draft
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Draft
sql/schemachanger: implement CREATE OR REPLACE TRIGGER#162633rafiss wants to merge 1 commit intocockroachdb:masterfrom
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, CREATE OR REPLACE TRIGGER returned an unimplemented error. This commit implements the feature by resolving any existing trigger with the same name on the table and dropping it before creating the replacement trigger with a new trigger ID. The approach follows the same pattern as DropTrigger: only the Trigger and TriggerDeps elements are explicitly dropped, and the dependent elements (TriggerName, TriggerEnabled, TriggerTiming, etc.) are cleaned up by the existing dependency rules. A new trigger ID is allocated for the replacement because the declarative schema changer does not allow re-adding an element with the same key as one dropped in the same transaction. The intermediate drop is safe because triggers cannot have dependents (nothing depends on a trigger), so there is no cascade concern. Fixes: cockroachdb#128422 Release note (sql change): CREATE OR REPLACE TRIGGER is now supported. If a trigger with the same name already exists on the same table, it is replaced with the new definition. If no trigger with that name exists, a new trigger is created. Epic: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, CREATE OR REPLACE TRIGGER returned an unimplemented error. This commit implements the feature by resolving any existing trigger with the same name on the table and dropping it before creating the replacement trigger with a new trigger ID.
The approach follows the same pattern as DropTrigger: only the Trigger and TriggerDeps elements are explicitly dropped, and the dependent elements (TriggerName, TriggerEnabled, TriggerTiming, etc.) are cleaned up by the existing dependency rules. A new trigger ID is allocated for the replacement because the declarative schema changer does not allow re-adding an element with the same key as one dropped in the same transaction.
The intermediate drop is safe because triggers cannot have dependents (nothing depends on a trigger), so there is no cascade concern.
Fixes: #128422
Release note (sql change): CREATE OR REPLACE TRIGGER is now supported. If a trigger with the same name already exists on the same table, it is replaced with the new definition. If no trigger with that name exists, a new trigger is created.