sql/schemachanger: add ALTER SEQUENCE to declarative schema changer#162634
Draft
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Draft
sql/schemachanger: add ALTER SEQUENCE to declarative schema changer#162634rafiss wants to merge 1 commit intocockroachdb:masterfrom
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This commit adds ALTER SEQUENCE support to the declarative schema changer. The implementation follows the same pattern as ALTER TABLE ALTER COLUMN ... SET/DROP IDENTITY, which already manipulates SequenceOption, SequenceValue, and SequenceOwner elements for identity-backing sequences. All existing elements and operations are reused - no new proto definitions are needed. The builder handles all ALTER SEQUENCE options: INCREMENT, MINVALUE, MAXVALUE, START, RESTART, CACHE (node and session), AS type changes (with implicit bounds adjustment), VIRTUAL, OWNED BY, OWNED BY NONE, and IF EXISTS. It is gated behind the V26_2 version check to ensure mixed-version compatibility. Epic: CRDB-31169 Release note: None
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds ALTER SEQUENCE support to the declarative schema changer. The implementation follows the same pattern as ALTER TABLE ALTER COLUMN ... SET/DROP IDENTITY, which already manipulates SequenceOption, SequenceValue, and SequenceOwner elements for identity-backing sequences. All existing elements and operations are reused - no new proto definitions are needed.
The builder handles all ALTER SEQUENCE options: INCREMENT, MINVALUE, MAXVALUE, START, RESTART, CACHE (node and session), AS type changes (with implicit bounds adjustment), VIRTUAL, OWNED BY, OWNED BY NONE, and IF EXISTS. It is gated behind the V26_2 version check to ensure mixed-version compatibility.
Epic: CRDB-31169
Release note: None