Skip to content

Add GitHub Updater support, fix bugs, and add EDD license tracking#1

Open
zackkatz wants to merge 14 commits intocode-atlantic:masterfrom
GravityKit:feature/github-updater-headers
Open

Add GitHub Updater support, fix bugs, and add EDD license tracking#1
zackkatz wants to merge 14 commits intocode-atlantic:masterfrom
GravityKit:feature/github-updater-headers

Conversation

@zackkatz
Copy link

@zackkatz zackkatz commented Feb 2, 2026 •
edited
Loading

Summary

GitHub Updater support

  • Add GitHub Plugin URI and Primary Branch headers to enable automatic plugin updates via Git Updater
  • Fill in missing plugin metadata (Description, Version, License, Requires PHP, Requires at least) and correct Plugin URI

Composer fix

  • Add vendor-prefixed/.gitkeep to fix composer classmap scan error on fresh clones

Fatal error fix

  • Fix TypeError in JSONEventTrackingHandler::register() where all hook callbacks referenced non-existent camelCase methods instead of the actual snake_case methods

Security fixes

  • Add authentication to /fluent-crm/v1/list-growth REST endpoint (require manage_options capability)
  • Add date parameter validation to prevent malformed input
  • Sanitize $prop_name in JSON_EXTRACT SQL queries to prevent SQL injection
  • Use bound parameters for all whereRaw LIKE queries (was using string interpolation)
  • Sanitize $_GET params before forwarding in SmartLink redirects

Bug fixes

  • Remove stray break in not_contains filter handler that silently skipped all remaining filters
  • Fix wrong variable check ($item_value → $trimmed_values) in UpdateContactPropertyAction::formatCustomFieldValues
  • Fix trailing ? or & appended to redirect URLs when no query params exist
  • Remove empty switch statement (dead code from incomplete implementation)

EDD license activation tracking

  • New EddLicenseActivationTracker class hooks into edd_sl_activate_license to record a FluentCRM event (license_activated) when a customer activates their license key
  • Enables funnel conditions to check "Has performed: Activated license key" for onboarding automation branching

EDD license status condition

  • New "EDD Licenses" condition group in the funnel condition block
  • Lists all EDD products with licenses; each can be checked for "Yes - Has active license" / "No - Does not have active license"
  • Resolves FluentCRM subscriber → EDD Customer and queries edd_licenses table for active/inactive status

Cleanup

  • Remove hardcoded debug email (daniel@code-atlantic.com) from event tracking
  • Remove no-op gettingAction() override in RandomWaitTimeAction
  • Remove dead code: commented-out hook, unused add_custom_dashboard_metrics(), placeholder register_custom_report/render_custom_report (Subscriber::all() memory issue)
  • Remove unnecessary Carbon dependency from REST endpoint
  • Prefix remaining global functions with customcrm_ to avoid namespace collisions

Test plan

  • Activate the plugin and verify no fatal errors on any FluentCRM admin page
  • Verify event tracking filters and condition groups load correctly in FluentCRM
  • Test SmartLink redirects preserve query parameters correctly and don't add trailing ?/&
  • Verify /fluent-crm/v1/list-growth endpoint returns 401 for unauthenticated requests
  • Test EDD subscription filters with various operator/status combinations
  • Install Git Updater and confirm this plugin can check for updates
  • Run composer install on a fresh clone and confirm no classmap scan error
  • Activate an EDD license and verify fc_event_tracking gets a license_activated row
  • In a funnel condition block, verify "EDD Licenses" group appears with per-product options
  • Test license condition evaluates correctly for contacts with/without active licenses

@zackkatz
Add GitHub Updater plugin headers for automatic updates
d0d7f87 
Add `GitHub Plugin URI` and `Primary Branch` headers to enable
automatic plugin updates via the Git Updater plugin. Also fill in
missing plugin metadata (Description, Version, License, Requires PHP,
Requires at least) and correct the Plugin URI to point to the current
repository.
@zackkatz
Add vendor-prefixed .gitkeep to fix composer classmap scan error
b3f2944 
The classmap autoload entry references the vendor-prefixed directory,
but the directory wasn't tracked in git, causing composer to fail with
"Could not scan for classes inside vendor-prefixed". Track the directory
via .gitkeep so it exists on fresh clones.
@zackkatz
Fix fatal error: register() callbacks reference non-existent camelCas…
eb1326b 
…e methods

The register() method hooked camelCase method names (e.g.,
addEventTrackingFilterOptions) but the actual methods use snake_case
(e.g., add_event_tracking_filter_options). This caused a fatal
TypeError on every page load where FluentCRM triggers these filters.
@zackkatz zackkatz changed the title Add GitHub Updater plugin headers Add GitHub Updater support and fix fatal error in event tracking Feb 2, 2026
@zackkatz
Fix security vulnerabilities, bugs, and dead code across plugin
d4c1a65 
Security fixes:
- Add authentication to REST endpoint (require manage_options capability)
- Add date parameter validation to prevent malformed input
- Sanitize $prop_name in SQL queries to prevent SQL injection
- Use bound parameters for all whereRaw LIKE queries
- Sanitize $_GET params before forwarding in SmartLink redirects

Bug fixes:
- Remove stray break in not_contains filter that skipped remaining filters
- Fix wrong variable check ($item_value → $trimmed_values) in
  UpdateContactPropertyAction::formatCustomFieldValues
- Fix trailing ?/& appended to redirect URLs when no query params exist
- Remove empty switch statement (dead code from incomplete implementation)

Cleanup:
- Remove hardcoded debug email (daniel@code-atlantic.com) from event tracking
- Remove no-op gettingAction() override in RandomWaitTimeAction
- Remove dead code: commented-out hook, unused add_custom_dashboard_metrics(),
  placeholder register_custom_report/render_custom_report (Subscriber::all()
  memory bomb)
- Remove Carbon dependency from REST endpoint (unnecessary)
- Prefix remaining global functions with customcrm_ to avoid collisions
@zackkatz
feat: add automation conditions and Drip merge tag migration
c797a5e 
- Add AutomationConditions class that registers event tracking and
  automation completion condition groups in FluentCRM's funnel condition
  block (fixes MAR-8 and MAR-9)
- Add FixDripMergeTags migration to convert Drip merge tags to FluentCRM
  equivalents in already-imported campaigns and funnel sequences (fixes MAR-12)
@zackkatz
fix: critical bugs in automation conditions and merge tag migration
64edb26 
- AutomationConditions: return $result instead of true to preserve
  prior filter results in condition chain
- FixDripMergeTags: guard against preg_replace returning null which
  would wipe email content
- FixDripMergeTags: add LIKE guard to funnel sequences query to avoid
  full table scan
@zackkatz
fix: fail-safe for unknown operators, complete campaign_emails migration
b9b03d9 
- AutomationConditions: unknown operators now fail safe instead of
  silently passing
- FixDripMergeTags: campaign_emails query now checks for
  inline_postal_address and account.name tags (matching campaigns query)
- FixDripMergeTags: campaign_emails loop now tracks stats (updated,
  skipped, errors) for complete reporting
@zackkatz
feat: track EDD license activations as FluentCRM events
5df99ce 
Hook into edd_sl_activate_license to record an event in fc_event_tracking
so funnel conditions can check "has performed: Activated license key".
@zackkatz
feat: add EDD license status condition for funnel automation
d0954b7 
New "EDD Licenses" condition group lets funnels check if a contact has
an active license for a specific product via the edd_licenses table.
@zackkatz zackkatz changed the title Add GitHub Updater support and fix fatal error in event tracking Add GitHub Updater support, fix bugs, and add EDD license tracking Feb 19, 2026
@zackkatz
feat: replace composer autoloader with simple PSR-4, add GH Actions r…
086fa1a 
…elease

No runtime composer dependencies exist, so replace vendor/autoload.php
with a lightweight spl_autoload_register. Add GitHub Actions workflow
that zips and creates a release on tag push.
@zackkatz
feat(email): add Custom CSS editor for FluentCRM email templates
0f299bf 
Allows injecting arbitrary CSS into all outgoing FluentCRM emails via
a new admin page (FluentCRM > Custom CSS) with a CodeMirror editor.

- New CustomEmailCSS class handles admin page, save, and email injection
- CSS injected before </head> after all template defaults for natural priority
- Sanitizes input against XSS vectors (expression(), @import, javascript:, etc.)
- Accessible: labeled textarea, role="alert" on notices, translatable strings
- Uses WordPress CodeMirror (wp_enqueue_code_editor) in CSS mode
@zackkatz
fix(email-css): auto-append !important and fix CodeMirror loading
7618b13 
- Auto-append !important to every CSS declaration at injection time so
  custom styles override inline styles and template !important rules
- Strip existing !important before re-adding to prevent doubling
- Fix CodeMirror not loading: check $_GET['page'] instead of hook suffix
  which varies depending on how FluentCRM registers its parent menu
- Update admin page description to reflect !important behavior
@zackkatz
feat(conditions): add granular EDD license status options
f5d74de 
The "Has active license" condition was a binary yes/no that matched both
active and inactive statuses. Automations needed finer control to
distinguish between specific license states.

- Replace yes/no with multi-select: Valid, Active, Inactive, Expired, Disabled
- "Valid" maps to active+inactive (non-expired, non-revoked)
- Add mapLicenseOptionToStatuses() for clean status resolution
- Backward-compatible: old yes/no values auto-convert to new format
- Guard against empty status arrays in whereIn queries
@zackkatz
fix: address CodeRabbit review findings across plugin
ae91ef2 
Multiple potential issues found during code review needed correcting to
prevent edge-case bugs and improve security hardening.

- SmartLinkHandler: use map_deep() for nested array sanitization
- EddLicenseActivationTracker: check $customer->id not truthy $customer
- UpdateContactPropertyAction: filter empty strings after trim
- FixDripMergeTags: track stats for funnel sequence updates/skips/errors
- CustomEmailCSS: fix wp_die() signature, null-coalesce preg_replace, prevent style tag breakout
- Main plugin: validate dates with checkdate(), include full day in whereBetween ranges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zackkatz