Initial Proposal for getting module support#124
Draft
tlf30 wants to merge 1 commit intocode-disaster:masterfrom
Draft
Initial Proposal for getting module support#124tlf30 wants to merge 1 commit intocode-disaster:masterfrom
tlf30 wants to merge 1 commit intocode-disaster:masterfrom
Conversation
|
Hi: Java 22 is about to release in 20 days https://partner.steamgames.com/doc/sdk/api & then upload this dependencies to maven central repository? I think this way could be easier to do Thanks |
Author
|
@chengenzhao please open your ideas as a separate issue. There is no reason to comment on foreign function api on a PR that has nothing to do with it. I'm not saying that it is a bad idea, just that this was an inappropriate place to comment on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #101:
This PR is an initial proposal to get a conversation going. What I changed:
The migration path for anyone using the library would be:
steamworks4j-serverdependencyUnit tests pass on my local machine, I have not yet thrown this into a project and done thorough testing yet though. If you like this path forward, I will do more testing before this gets merged.
Thanks,
Trevor