Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thank you for this library @code-disaster!
For my game on Steam I have used
SteamNetworking. Over time, I have received frequent complaints from players about unstable P2P matchmaking, connection drops and lag. Especially Chinese players seem to have lots of issues on the 'legacy' networking.I took the existing fork from Tyler as base, with the following changes:
Connection,SocketandSteamIdvalues over raw ints or longsConnectionStateenum over raw ints in callbackSendFlagsbitflags as constants (here int seems to be the more natural choice)receiveMessageOnConnectiondoes not allocateenableSymmetricConnect, because it simplified P2P handshakes a lotThis is already running in production and so far I have only received positive feedback from players.
I'd really love to see this integrated, and I'm more than happy to change or refine anything needed to make that happen.