Skip to content

Fix DataTypes::UpdateService to not be order dependent for received DataTypes #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Taucher2003 merged 1 commit into from
Jan 12, 2026
Merged

Fix DataTypes::UpdateService to not be order dependent for received DataTypes #826

Taucher2003 merged 1 commit into from
Jan 12, 2026

Conversation

@Taucher2003
Copy link
Member

@Taucher2003 Taucher2003 commented Jan 12, 2026

Also fixes the detail option for the JsonSchemaValidator and the JsonSchema for the GenericMapper

Closes #825

@Taucher2003 Taucher2003 self-assigned this Jan 12, 2026
@github-actions
Copy link

github-actions bot commented Jan 12, 2026 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2258666047

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12687539531/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2258666047/test_report
Finished in 23.82 seconds (files took 12.67 seconds to load)
1323 examples, 0 failures
Line Coverage: 91.47% (4546 / 4970)
[TEST PROF INFO] Time spent in factories: 00:12.958 (43.21% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12687539530/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2258666047/test_report
Finished in 22.84 seconds (files took 9.83 seconds to load)
1276 examples, 0 failures
Line Coverage: 90.92% (4378 / 4815)
[TEST PROF INFO] Time spent in factories: 00:12.623 (44.16% of total time)

rubocop

730 files inspected, no offenses detected

@Taucher2003
Fix DataTypes::UpdateService to not be order dependent for received D…
f57174d 
…ataTypes

Also fixes the detail option for the JsonSchemaValidator and the JsonSchema
for the GenericMapper
@Taucher2003 Taucher2003 force-pushed the 825-fix-data-type-update-order-dependence branch from c2e2871 to f57174d Compare January 12, 2026 19:04
@Taucher2003 Taucher2003 merged commit f35f409 into main Jan 12, 2026
1 check passed
@Taucher2003 Taucher2003 deleted the 825-fix-data-type-update-order-dependence branch January 12, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Taucher2003 Taucher2003

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataTypes::UpdateService is order dependent

2 participants

@Taucher2003