Skip to content

Conversation

@surdu
Copy link
Member

@surdu surdu commented Jun 2, 2020

What changed?

Using Storybook Knobs in order to control variations on a component.

Actions (optional)

  • Increase the version of the package if you need to release it after the merge
  • If you added a new component, please make sure to export it in ../src/index.js

@vercel
Copy link

vercel bot commented Jun 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/i3xuuvka7
✅ Preview: https://taskforce-fe-components-git-feature-knobs.code4romania.vercel.app

@surdu
Copy link
Member Author

surdu commented Jun 2, 2020

Pros: You don't have to scroll to many instances of the same component in storybook: you have only one component with a UI to control all aspects of it.

Cons: Might not be as intuitive how to use the component looking at the storybook code

@moonflare , @Utwo Opinions? Before I start switching all components to use knobs :)

@surdu surdu requested review from Utwo and moonflare June 4, 2020 21:28
@Utwo
Copy link
Member

Utwo commented Oct 9, 2020

I think it's more elegant with knobs but I don't know if it's worth the effort.

@surdu
Copy link
Member Author

surdu commented Oct 9, 2020

I don't know if it's worth the effort

too late 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants