Bug in SassScriptLexer.php in PHP 7: substr() now returns empty string instead of false. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove the type strict check. Without this the loop never ends and the script runs out of memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file contains a loop checking if
$string !== false. Because of this subtle change in PHP 7, the loop while statement evaluates as"" !== falsewhich always returns true. The loop continues forever until PHP runs out of memory.The simple fix is to replace the exact type check of
!==with simply!=. Then whensubstr()returns an empty string, the comparison returns false and the loop breaks at the proper time.