[박다슬] sprint11#272
Merged
JiNookk merged 1 commit intocodeit-bootcamp-nodejs:박다슬from Dec 3, 2025
Hidden character warning
The head ref may contain hidden characters: "\ubc15\ub2e4\uc2ac-sprint11"
Merged
Conversation
JiNookk
approved these changes
Dec 3, 2025
Collaborator
JiNookk
left a comment
JiNookk
left a comment
There was a problem hiding this comment.
수고하셨습니다~ 코멘트 한번만 확인 부탁드려요!
| @@ -0,0 +1,68 @@ | |||
| name: PR test Check (DB 포함) | |||
Collaborator
There was a problem hiding this comment.
Postgres 컨테이너까지 띄워서 통합 테스트를 안정적으로 실행하는 것 좋네요!
| # 1단계: 빌드 스테이지 (Builder Stage) | ||
| # ---------------------------------------------------------------------- | ||
| ARG NODE_VERSION= | ||
| FROM node:${NODE_VERSION}-slim AS builder |
Collaborator
There was a problem hiding this comment.
github action에서는 괜찮을 것 같은데 docker-compose에서는 NODE_VERSION환경변수가 빠져서 보완이 필요할 것 같습니다.
| @@ -0,0 +1,37 @@ | |||
| node_modules | |||
Collaborator
There was a problem hiding this comment.
개발 관련 파일, 테스트 파일 잘 제외하셨네요!
| id: build-image | ||
| env: | ||
| ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} | ||
| IMAGE_TAG: ${{ github.sha }} |
| -e DATABASE_URL='${{ secrets.DATABASE_URL }}' \ | ||
| ${{ env.IMAGE_URI }} | ||
|
|
||
| - name: Remove Runner IP from EC2 Security Group |
| - '3000:3000' | ||
| env_file: | ||
| - ./.env | ||
| volumes: |
Collaborator
There was a problem hiding this comment.
전체 소스 마운트하는게 개발환경에서는 편리한데 프로덕션에서는 빌드된 이미지만 포함하는게 좋아요~ 환경을 분리해서 docker-compose를 작성해보면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
Github Actions 활용
Docker 이미지 만들기
주요 변경사항
멘토에게