Fix SpotBugs "Condition has no effect" warnings #4366
Draft
+100
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated .github/scripts/generate-quality-report.py to fail on UC_USELESS_CONDITION. Fixed UC_USELESS_CONDITION warnings in: - CodenameOne/src/com/codename1/ui/layouts/mig/Grid.java - CodenameOne/src/com/codename1/ui/MenuBar.java - CodenameOne/src/com/codename1/util/MathUtil.java - CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java - CodenameOne/src/com/codename1/ui/Component.java - CodenameOne/src/com/codename1/ui/ComponentGroup.java - CodenameOne/src/com/codename1/ui/html/CSSEngine.java - CodenameOne/src/com/codename1/ui/html/CSSParser.java - CodenameOne/src/com/codename1/ui/html/HTMLComponent.java - CodenameOne/src/com/codename1/ui/html/ResourceThreadQueue.java - CodenameOne/src/com/codename1/ui/layouts/mig/UnitValue.java - CodenameOne/src/com/codename1/util/regex/RECharacter.java - CodenameOne/src/com/codename1/xml/XMLParser.java
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Collaborator
Android screenshot updatesCompared 30 screenshots: 29 matched, 1 updated.
Native Android coverage
|
Collaborator
iOS screenshot updatesCompared 30 screenshots: 23 matched, 6 updated, 1 missing reference.
Benchmark Results
Detailed Performance Metrics
|
Fixed multiple occurrences of UC_USELESS_CONDITION warnings across 13 files. Updated .github/scripts/generate-quality-report.py to fail on this violation. Notable fixes: - CSSParser.java: Fixed char to byte cast comparison that caused premature EOF on extended ASCII. - ResourceThreadQueue.java: Fixed variable shadowing and added volatile to cancelled flag. - UnitValue.java: Fixed condition checking operation type. - XMLParser.java: Used Character.toLowerCase instead of manual range check. - Various cleanups in Grid.java, MenuBar.java, Component.java, etc.
Fixed UC_USELESS_CONDITION warnings across 13 files and resolved a compilation error in ComponentGroup.java. Updated .github/scripts/generate-quality-report.py to fail on this violation. Notable fixes: - ComponentGroup.java: Added missing import for Layout class. - CSSParser.java: Fixed char to byte cast comparison that caused premature EOF on extended ASCII. - ResourceThreadQueue.java: Fixed variable shadowing and added volatile to cancelled flag. - UnitValue.java: Fixed condition checking operation type. - XMLParser.java: Used Character.toLowerCase instead of manual range check. - Various cleanups in Grid.java, MenuBar.java, Component.java, etc.
Resolves "Condition has no effect" warnings in: - HTMLComponent.java (Redundant SUPPORT_CSS check, fix variable shadowing) - CSSEngine.java (Redundant indent >= 0 check) - CSSParser.java (Incorrect EOF check for char) - RECharacter.java (Duplicate whitespace check) - Updated generate-quality-report.py to enforce this rule.
Resolves "Condition has no effect" warnings in: - HTMLComponent.java (Redundant else/assignment) - CSSEngine.java (Redundant getUi() != null check) - CSSParser.java (Redundant EOF check) - RECharacter.java (Duplicate check) - ResourceThreadQueue.java (Simplified boolean check) - Component.java (Redundant isFlatten() || !opaque check) - CodenameOneImplementation.java (Redundant width/height check) - MathUtil.java (Redundant huge + x > one check) - MenuBar.java (Dead code removal for ICS check) - ComponentGroup.java (Refactored logic) - Updated generate-quality-report.py to enforce this rule.
Resolves "Condition has no effect" warnings in: - CodenameOneImplementation.java (Redundant width/height check) - MathUtil.java (Redundant huge + x > one check) - Component.java (Redundant isFlatten() || !opaque check) - HTMLComponent.java (Redundant else/assignment) - ResourceThreadQueue.java (Simplified boolean check) - CSSEngine.java (Redundant getUi() != null check) - CSSParser.java (Redundant EOF check) - MenuBar.java (Dead code removal for ICS check) - ComponentGroup.java (Refactored logic) - Updated generate-quality-report.py to enforce this rule.
This change resolves "Condition has no effect" (UC_USELESS_CONDITION) warnings reported by SpotBugs in several core classes including Component, MenuBar, CSSEngine, CSSParser, and MathUtil. It also updates the quality report generation script to enforce this rule in CI. Key changes: - `Component.java`: Refactored `paintLock` logic to remove redundant checks. - `ComponentGroup.java`: Simplified boolean logic in `updateUIIDs` to avoid redundancy. - `MenuBar.java`: Removed dead code related to deprecated ICS command behavior. - `CSSEngine.java`: Made `fontSize` range check explicit. - `CSSParser.java`: Improved EOF check readability in whitespace loop. - `MathUtil.java`: Removed redundant floating-point precision checks in `asin` and `atan`. - `.github/scripts/generate-quality-report.py`: Added `UC_USELESS_CONDITION` to the list of enforced rules.
Fixed multiple instances of 'Condition has no effect' (UC_USELESS_CONDITION) in core classes including Grid, MenuBar, MathUtil, Component, and others. Updated generate-quality-report.py to treat this violation as a build failure.
Fixed multiple instances of 'Condition has no effect' (UC_USELESS_CONDITION) in core classes: * CodenameOne/src/com/codename1/util/MathUtil.java: Fixed bitwise shift logic in `ieee754_pow` (`>>>` to `>>`) to restore correct negative number handling. * CodenameOne/src/com/codename1/ui/MenuBar.java: Removed redundant `COMMAND_BEHAVIOR_ICS` check. * CodenameOne/src/com/codename1/ui/Component.java: Removed duplicate `!animateBackground` check. * CodenameOne/src/com/codename1/ui/ComponentGroup.java: Removed redundant `if (count > 1)` check. * CodenameOne/src/com/codename1/ui/html/CSSParser.java: Removed redundant whitespace check. * CodenameOne/src/com/codename1/ui/html/HTMLComponent.java: Removed redundant whitespace check. * CodenameOne/src/com/codename1/xml/XMLParser.java: Removed redundant whitespace check. * CodenameOne/src/com/codename1/ui/html/CSSEngine.java: Removed redundant whitespace check. * CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java: Refactored `setCommandBehavior` condition logic.
Addressed persistent SpotBugs warnings in core classes: * CodenameOne/src/com/codename1/util/MathUtil.java: Removed redundant `if (ix >= 0x3ff00000)` check in `ieee754_pow` as it is logically implied by previous conditions. * CodenameOne/src/com/codename1/ui/MenuBar.java: Removed redundant `COMMAND_BEHAVIOR_SIDE_NAVIGATION` check which was impossible in the given context. * CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java: Removed redundant `(c == 10)` check in `isWhitespace` as `\n` (10) was already checked. * CodenameOne/src/com/codename1/ui/html/HTMLComponent.java, CSSParser.java, XMLParser.java, CSSEngine.java: Standardized whitespace checks to remove redundancy (`\n` vs 10) and ensured consistency. These fixes clean up logic errors and redundant code flagged by strict static analysis.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Fixed multiple instances of 'Condition has no effect' (UC_USELESS_CONDITION) in core classes. Restored `MathUtil.ieee754_pow` to use logical right shift (`>>>`) to preserve original behavior for negative inputs, while removing the dead code blocks that SpotBugs flagged to resolve the static analysis violation. Fixes: * CodenameOne/src/com/codename1/util/MathUtil.java: Reverted `n` calculation to `>>>` and removed dead code blocks. * CodenameOne/src/com/codename1/ui/MenuBar.java: Removed redundant `COMMAND_BEHAVIOR_SIDE_NAVIGATION` check. * CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java: Removed redundant `(c == 10)` check in `isWhitespace`. * CodenameOne/src/com/codename1/ui/html/HTMLComponent.java, CSSParser.java, XMLParser.java, CSSEngine.java: Standardized whitespace checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed SpotBugs "Condition has no effect" (UC_USELESS_CONDITION) warnings in several files and updated the quality report script to fail on these warnings.
PR created automatically by Jules for task 17199185989857704409 started by @shai-almog